Skip to content

[16.0][ADD] pos_partner_pricelist_load_background#1243

Merged
OCA-git-bot merged 1 commit intoOCA:16.0from
camptocamp:16.0-add-pos_partner_pricelist_load_background
Mar 5, 2026
Merged

[16.0][ADD] pos_partner_pricelist_load_background#1243
OCA-git-bot merged 1 commit intoOCA:16.0from
camptocamp:16.0-add-pos_partner_pricelist_load_background

Conversation

@santostelmo
Copy link
Copy Markdown

@santostelmo santostelmo commented Sep 25, 2024 •
edited by gurneyalex
Loading

This module allow you to load a pricelist for a customer in the background.

Context
In the POS, we can configure a list of available pricelists. These price lists are loaded during start-up and only these can be chosen for any order.
When a customer is selected, the POS will try to find the customer's pricelist (property_pricelist_id) among the available pricelists.
If it's found, the pricelist is selected otherwise a default one will be selected instead.

With this module
When a customer is selected, their pricelist (property_pricelist_id) is loaded and available to be chosen.

@santostelmo santostelmo changed the title [ADD]pos_partner_pricelist_load_background [16.0][ADD]pos_partner_pricelist_load_background Sep 25, 2024
@santostelmo santostelmo force-pushed the 16.0-add-pos_partner_pricelist_load_background branch 4 times, most recently from 17fe4ae to 9c85e95 Compare September 25, 2024 06:39
@santostelmo santostelmo changed the title [16.0][ADD]pos_partner_pricelist_load_background [16.0][ADD] pos_partner_pricelist_load_background Sep 25, 2024
@santostelmo santostelmo force-pushed the 16.0-add-pos_partner_pricelist_load_background branch 2 times, most recently from 6d711b5 to 149711f Compare September 25, 2024 12:40
@santostelmo santostelmo mentioned this pull request Sep 25, 2024
Merged
@santostelmo santostelmo force-pushed the 16.0-add-pos_partner_pricelist_load_background branch 9 times, most recently from 6e61464 to 3397d48 Compare October 1, 2024 09:51
cyrilmanuel
cyrilmanuel approved these changes Oct 1, 2024
View reviewed changes
Copy link
Copy Markdown

@cyrilmanuel cyrilmanuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not an expert but LGTM

@santostelmo santostelmo force-pushed the 16.0-add-pos_partner_pricelist_load_background branch from 3397d48 to ee52209 Compare October 4, 2024 09:51
@santostelmo santostelmo force-pushed the 16.0-add-pos_partner_pricelist_load_background branch from d813f16 to b6d0567 Compare January 21, 2025 06:55
@santostelmo santostelmo force-pushed the 16.0-add-pos_partner_pricelist_load_background branch from b6d0567 to 8979a5d Compare January 28, 2025 10:08
simahawk
simahawk reviewed Jan 31, 2025
View reviewed changes
pos_partner_pricelist_load_background/models/pos_session.py
class POSSession(models.Model):
_inherit = "pos.session"

def get_pos_ui_partner_pricelist_background(self, pricelist_id, product_ids):
Copy link
Copy Markdown

@simahawk simahawk Jan 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice to see a docstring and a test for this

Copy link
Copy Markdown
Author

@santostelmo santostelmo Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added doc string and unit test.

@santostelmo santostelmo force-pushed the 16.0-add-pos_partner_pricelist_load_background branch from 8979a5d to 8ac4677 Compare February 3, 2025 08:15
@santostelmo santostelmo force-pushed the 16.0-add-pos_partner_pricelist_load_background branch 2 times, most recently from 7db1a6d to 51cd598 Compare February 24, 2025 06:44
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 29, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 29, 2025
@github-actions github-actions bot closed this Aug 3, 2025
@gurneyalex gurneyalex reopened this Mar 3, 2026
@cyrilmanuel cyrilmanuel force-pushed the 16.0-add-pos_partner_pricelist_load_background branch from 51cd598 to 80019ee Compare March 3, 2026 12:20
@cyrilmanuel
Copy link
Copy Markdown

cyrilmanuel commented Mar 3, 2026

hi @OCA/pos-maintainers could we merge this PR please :)

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Mar 3, 2026

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

1 similar comment
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Mar 3, 2026

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@gurneyalex
Copy link
Copy Markdown
Member

gurneyalex commented Mar 5, 2026

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Mar 5, 2026

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1243-by-gurneyalex-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d842343 into OCA:16.0 Mar 5, 2026
7 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Mar 5, 2026

Congratulations, your PR was merged at cdf4062. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simahawk simahawk simahawk left review comments

@gurneyalex gurneyalex gurneyalex approved these changes

+1 more reviewer

@cyrilmanuel cyrilmanuel cyrilmanuel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 ready to merge stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@santostelmo @cyrilmanuel @OCA-git-bot @gurneyalex @simahawk